Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap log file size at 10MB #201

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Conversation

joelekstrom
Copy link
Contributor

Uses the new code in BuildaUtils to automatically split log files when they reach 10MB. Be aware that it won't automatically delete old log files (but I suppose that's not something a sysadmin expects by default)

Fixes #142

@buildasaur
Copy link
Collaborator

Result of Integration 1

Duration: 5 minutes and 43 seconds
Result: Perfect build! All 33 tests passed. 👍
Test Coverage: 23%

@czechboy0
Copy link
Member

Thanks! Just two little things:

  1. You'll need to merge master into this branch first, there are conflicts and I can't merge it.
  2. Can you please run pod install with the latest public CocoaPods (0.39.0) please? The lockfile otherwise gets overwritten to an older version.

Thanks again, great work on this. 👍

@joelekstrom
Copy link
Contributor Author

Fixed. I use an old Cocoapods-version because 0.39 breaks a few pods that I need for work projects :(

@buildasaur
Copy link
Collaborator

Result of Integration 2

Duration: 1 hour, 38 minutes and 53 seconds
Result: -1 error, failing state: trigger-error

@buildasaur
Copy link
Collaborator

Result of Integration 3

Duration: 4 minutes and 51 seconds
Result: Perfect build! All 33 tests passed. 👍
Test Coverage: 23%

czechboy0 added a commit that referenced this pull request Jan 19, 2016
Cap log file size at 10MB
@czechboy0 czechboy0 merged commit 12065a8 into buildasaurs:master Jan 19, 2016
@czechboy0
Copy link
Member

Awesome, thanks for this! 🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants