Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable App Transport Security to connect to self-signed XCS #134

Merged
merged 2 commits into from
Sep 25, 2015
Merged

Disable App Transport Security to connect to self-signed XCS #134

merged 2 commits into from
Sep 25, 2015

Conversation

Brett-Best
Copy link
Contributor

Added ATS key to Info PLISTs.

@Brett-Best Brett-Best mentioned this pull request Sep 25, 2015
@buildasaur
Copy link
Collaborator

Result of Integration 1

Duration: 2 minutes and 3 seconds
Result: All 19 tests passed, but please fix 3 warnings.
Test Coverage: 23%.

@czechboy0
Copy link
Member

Are you sure it needs to be added to all the Info.plists? I think I tried adding it to just the Buildasaur (the app) target and that was enough. Please try to remove the rest and see whether it still works, thanks 👍

@czechboy0 czechboy0 changed the title feature/disable-app-transport-security Disable App Transport Security to connect to self-signed XCS Sep 25, 2015
@Brett-Best
Copy link
Contributor Author

@czechboy0 on my local machine I had to add it all of them but the test targets. I added them to the test targets encase you added tests that would break depending on the server the were against.

@Brett-Best
Copy link
Contributor Author

@czechboy0 looks like it only needed to be on the one target after all.

@Brett-Best Brett-Best closed this Sep 25, 2015
@Brett-Best Brett-Best reopened this Sep 25, 2015
@buildasaur
Copy link
Collaborator

Result of Integration 1

Duration: 2 minutes and 17 seconds
Result: All 19 tests passed, but please fix 3 warnings.
Test Coverage: 23%.

@czechboy0
Copy link
Member

Brilliant, thank you, @Brett-Best! 👍

czechboy0 added a commit that referenced this pull request Sep 25, 2015
…-security

Disable App Transport Security to connect to self-signed XCS
@czechboy0 czechboy0 merged commit 06360e6 into buildasaurs:master Sep 25, 2015
@Brett-Best Brett-Best deleted the feature/disable-app-transport-security branch September 26, 2015 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants