Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Storage #137

Closed
Brett-Best opened this issue Sep 28, 2015 · 6 comments
Closed

Password Storage #137

Brett-Best opened this issue Sep 28, 2015 · 6 comments

Comments

@Brett-Best
Copy link
Contributor

Currently credentials are stored in plain text.

Change to use the keychain instead.

@czechboy0
Copy link
Member

Just FYI, I'm doing huge refactoring in #138, so you might want to hold off on this task for a couple of days. Otherwise it might be a pain to even merge it :)

@Brett-Best
Copy link
Contributor Author

@czechboy0 that's fine :) will do.

@Brett-Best
Copy link
Contributor Author

@czechboy0 is this good to go now?

@czechboy0
Copy link
Member

Yes, the big refactoring has been merged. Feel free to use this issue to track progress and ideas, let's discuss how you'll structure the change before you start so that we consider all aspects of it :)

@czechboy0
Copy link
Member

FYI, @Brett-Best. I'm taking over this one. I need it done for more work that's queued.

@czechboy0 czechboy0 self-assigned this Jan 22, 2016
@czechboy0 czechboy0 added this to the v0.8 - BitBucket support milestone Jan 23, 2016
@czechboy0
Copy link
Member

This has been merged into the v0.8 development branch, so don't expect it in v0.7 yet. Closing to not be in the list of open issues though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants