Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple repositories #12

Closed
mdio opened this issue Apr 30, 2015 · 10 comments
Closed

Support multiple repositories #12

mdio opened this issue Apr 30, 2015 · 10 comments

Comments

@mdio
Copy link
Contributor

mdio commented Apr 30, 2015

You asked for it. ;)

It would be nice to be able to watch multiple repositories at the same time from the same machine.
Maybe a simple approach would be to allow multiple instances of Buildasaur running at the same time.

The only problem would be the 5000 requests limit which are used up by all instances but then one could simply configure each instance to poll less frequently.

@czechboy0
Copy link
Member

Yeah this is also a good one, actually I wrote Buildasaur with this in mind, but I just haven't built the UI for it yet. You can see here that we load an array of Syncers, just right now only one Syncer runs at one time, but the whole architecture is built for multiple projects to be synced at the same time.

Regarding the GitHub limit, I'll investigate in #13 whether generating a new token for each synced project would help or whether it's user-based. But currently the 5000 per hour limit should be plenty, especially if you use a sync interval of 15 seconds or higher, because each sync kicks off cca n + k GitHub calls (where n is the number of open pull requests and k is a small constant ~ 2, mostly guessing here though). So my guess is that with a 15 sec sync interval and < 20 open pull requests, you shouldn't be hitting the rate limit. I'll look at it closer though. Let me know if you have any ideas on this topic.

@czechboy0
Copy link
Member

Since #13 proved that the 5000ph rate limit is per user, not per token, we need to find some decent sync frequencies to keep all repositories up to date and responsive to commands/builds, while not exhausting the rate limit. Currently for 1 repo (all that is supported atm), 15 seconds is a very good sync frequency that still keeps some head room under the rate limit.

@czechboy0
Copy link
Member

Damn, this really needs to happen. Now I have two repos I'd like to observe, XcodeServerSDK and Buildasaur. Priority high!

@czechboy0 czechboy0 modified the milestone: Gladiolus: Buildasaur 1.0 Jul 3, 2015
@stevesparks
Copy link

@czechboy0 What is the status of this issue? I have multiple repos I would like to watch.

@czechboy0
Copy link
Member

Buildasaur doesn't yet support that, it's a feature scheduled for 1.0. I can't give you any specific dates yet, but I welcome any help through Pull Request :)

@czechboy0 czechboy0 added task-large and removed UI labels Sep 25, 2015
@czechboy0 czechboy0 modified the milestones: Multi-repo support, Gladiolus: Buildasaur 1.0 Sep 29, 2015
@czechboy0 czechboy0 mentioned this issue Oct 5, 2015
3 tasks
@czechboy0
Copy link
Member

Hey @mdio, I'm happy to tell you that after 6 months I finally got to this. Multi-repo support has been merged in master and will appear in a beta later today.

Sooo... Thanks for reporting this back then! 👍

@mdio
Copy link
Contributor Author

mdio commented Oct 13, 2015

Hi, @czechboy0. Thanks for pinging me.
Unfortunately, the company I developed (and used Buildasaur) for went out of business a few months ago. So I don't use Buildasaur at the moment.

But I'm happy to see that more and more people are using your cool tool and if I get back into iOS development, I'll be happy to have multi-repo support in Buildasaur. :)

@czechboy0
Copy link
Member

Sorry to hear the first part, but 👍 for the second

@grantjk
Copy link

grantjk commented Oct 13, 2015

🍻 We've been anxiously awaiting this.... 🎉

@czechboy0
Copy link
Member

Looking forward to all feedback, @grantjk! (and @stevesparks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants