Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between optandcalcCCM and makeoptimizationplots #11

Open
fermosc opened this issue May 25, 2015 · 0 comments
Open

Differences between optandcalcCCM and makeoptimizationplots #11

fermosc opened this issue May 25, 2015 · 0 comments

Comments

@fermosc
Copy link

fermosc commented May 25, 2015

Hi,

I've been trying to use your library, which I think can be extremely useful. I would like to access the actual results from the calculations (rather than just get the plots using makeoptimizationplots as you describe in the manual), and from your code it seems like this would be done by optandcalcCCM. As I was getting very different results using each function, I went into the source code. There seem to be two differences in how the results are calculated, which makes me suspect one of them can be a bug.

  1. The following code in optandcalcCCM:
libsizemin_12 = max(res12["E"] + b_offset + 1, libsizemin)
libsizemin_21 = max(res21["E"] + b_offset + 1, libsizemin)

corresponds, in makeoptimizationplots, to:

libsizemin_12 = max(res12["E"] + b_offset + 1, 10)
libsizemin_21 = max(res21["E"] + b_offset + 1, 10)

which I suspect might not be desired.

  1. When calling calcCCM in makeoptimizationplots, you set a parameter lib_start=1, which is not done in the corresponding calls in optandcalcCCM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant