fix: edge cases during cy.type in number input #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jennifer-shehane
approved these changes
Dec 23, 2019
kuceb
changed the title
This was referenced Dec 23, 2019
brian-mann
reviewed
Dec 23, 2019
| @@ -260,7 +260,11 @@ const shouldUpdateValue = (el: HTMLElement, key: KeyDetails, options) => { | |||
|
|
|||
| if (!(numberRe.test(potentialValue))) { | |||
| debug('skipping inserting value since number input would be invalid', key.text, potentialValue) | |||
| options.prevVal = needsValue + key.text | |||
| if (key.text.match(/[-+eE\d\.]/)) { | |||
There was a problem hiding this comment.
this regexp should be hoisted to the top and given a variable name to help describe what it is
There was a problem hiding this comment.
also a description would be helpful
Comment on lines
+484
to
+486
| if (!$elements.isInput(el)) { | ||
| $selection.replaceSelectionContents(el, '\n') | ||
| } |
There was a problem hiding this comment.
a description of why this is necessary would be helpful here.
kuceb
added a commit
that referenced
this pull request
Dec 23, 2019
brian-mann
pushed a commit
that referenced
this pull request
Dec 23, 2019
avallete
pushed a commit
to avallete/cypress
that referenced
this pull request
Jan 8, 2020
Fix edge case introduced into cypress-io#6033 about typing invalid number Fixes cypress-io#6055
5 tasks
jennifer-shehane
added a commit
that referenced
this pull request
Jan 10, 2020
Fix edge case introduced into #6033 about typing invalid number Fixes #6055 Co-authored-by: Jennifer Shehane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{enter} in input type=number
.type()does not type chars in number input beyond special chars (like,) #5997allow non-number chars in number input
User facing changelog
Additional details
How has the user experience changed?
PR Tasks