-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect URL malformed if # is present #8407
Comments
This comment has been minimized.
This comment has been minimized.
@jennifer-shehane It doesnt appear the issue above is related to #8361 . I've upgraded to 5.1.0 and I'm still encountering this bug. The path in the error: "Users/dknott/Desktop/Songtrust-E2E" is the parent directory for my local Cypress project. To confirm, you were able to run the sample code I provided without hitting this Webpack Compilation Error? |
Confirmed this is the same # in the URL bug as before, just the error is different. Happening in 5.3.0 and 5.5.0. |
Yeah, I think I may have commented on the wrong issue above actually. Can anyone provide a reproducible example? The example provided does not reproduce the error and is missing some custom command definitions. |
@jennifer-shehane it's interesting. I think it actually might be related to newer versions of Chrome in conjunction with newer Cypress versions. I was able to use Cypress 5.3 and Chrome v69 and can get around this issue now. Unfortunately our code is private and can't be shared but like I've mentioned it's anytime there is a # in the URL which is common for Single Page Angular Applications. |
@jennifer-shehane I created #8507 after this was closed, which has more detail and an actual reproducible example. We can probably move this conversation there? |
Duplicate of #8507 |
Hi @jennifer-shehane ,
Moving this to a new ticket as requested.
Revisiting this, after updating to version Cypress 5.0.0 I'm still getting this redirect error. The message in the cypress client is different now though. You can see the redirect is still resolving to https://app.songtrust.com/__/#add/success/{id} (stripping out the /songwriter/ ).
The test is passing with this error when I run it locally, but fails command line (or in CI). Command line client crashes with "The automation client disconnected. Cannot continue running tests."
I am using experimentalSourceRewriting: true in my config.
Sample code:
Originally posted by @dwineknott in #1244 (comment)
The text was updated successfully, but these errors were encountered: