Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Hooks [TR-5] #7779

Closed
panzarino opened this issue Jun 22, 2020 · 2 comments · Fixed by #7821
Closed

Split Hooks [TR-5] #7779

panzarino opened this issue Jun 22, 2020 · 2 comments · Fixed by #7821
Assignees
@panzarino
Labels
pkg/driver This is due to an issue in the packages/driver directory type: enhancement Requested enhancement of existing feature type: user experience Improvements needed for UX

Comments

@panzarino
Copy link
Contributor

panzarino commented Jun 22, 2020 •
edited
Loading

User Story: When viewing executed tests in the Test Runner, I want to see hooks split out to be their own definitions, so that I can more easily identify the hooks running around my tests.

Acceptance Criteria

  • Split each command in any hook into its own definition in the Test Runner.
  • Append the command count each hook definition
  • Ex: a beforeEach running three commands, the user would see:
    • beforeEach (1)
    • beforeEach (2)
    • beforeEach (3)

Design:
Screen Shot 2020-06-22 at 6 54 05 PM
@panzarino panzarino added type: enhancement Requested enhancement of existing feature pkg/driver This is due to an issue in the packages/driver directory type: user experience Improvements needed for UX labels Jun 22, 2020
@panzarino panzarino self-assigned this Jun 22, 2020
@panzarino panzarino changed the title Split Hooks and Open in IDE [TR-5] Split Hooks [TR-5] Jun 22, 2020
@panzarino panzarino mentioned this issue Jun 24, 2020
Closed
5 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Jun 24, 2020
@panzarino panzarino mentioned this issue Jun 26, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review labels Jun 26, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 7, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2020

The code for this is done in cypress-io/cypress#7821, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2020

Released in 4.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@panzarino panzarino

Labels
pkg/driver This is due to an issue in the packages/driver directory type: enhancement Requested enhancement of existing feature type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
1 participant
@panzarino