Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check how browser logo icons and colors are assigned #5745

Closed
bahmutov opened this issue Nov 19, 2019 · 2 comments · Fixed by #5746 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Closed

check how browser logo icons and colors are assigned #5745

bahmutov opened this issue Nov 19, 2019 · 2 comments · Fixed by #5746 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Assignees
@jennifer-shehane
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX

Comments

@bahmutov
Copy link
Contributor

In the browser dropdown (especially with upcoming cross-browser support) it looks weird

Screen Shot 2019-11-19 at 2 33 07 PM

for #1359
@jennifer-shehane jennifer-shehane mentioned this issue Nov 27, 2019
Merged
2 tasks
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Nov 27, 2019
@jennifer-shehane jennifer-shehane added type: user experience Improvements needed for UX pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory labels Dec 10, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 10, 2019

The code for this is done in cypress-io/cypress#5746, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Dec 10, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 12, 2019

Released in 3.8.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jennifer-shehane jennifer-shehane

Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @bahmutov