You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cypress associates the PR for the GitHub integration by the commit SHA sent via environment variables from the CI provider. Travis's docs mentions sending these a bit different than other CI providers here:
Rather than build the commits that have been pushed to the branch the pull request is from, we build the merge between the source branch and the upstream branch. https://docs.travis-ci.com/user/pull-requests/
The code for this is done in cypress-io/cypress#5714, but has yet to be released.
We'll update this issue and reference the changelog when it's released.
Current behavior:
Cypress associates the PR for the GitHub integration by the commit SHA sent via environment variables from the CI provider. Travis's docs mentions sending these a bit different than other CI providers here:
Currently Cypress looks for
TRAVIS_COMMIT
, but supplying theTRAVIS_PULL_REQUEST_SHA
(https://docs.travis-ci.com/user/environment-variables/) resolves this SHA mixup.Desired behavior:
A status check for GitHub should run on both commit and PR initiated build from Travis.
Steps to reproduce: (app code and test code)
Some experimenting here: cypress-io/cypress-example-kitchensink#328
Versions
3.6.1
The text was updated successfully, but these errors were encountered: