Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect GitHub Actions CI better #5609

Closed
bahmutov opened this issue Nov 5, 2019 · 3 comments · Fixed by #5687 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Closed

Detect GitHub Actions CI better #5609

bahmutov opened this issue Nov 5, 2019 · 3 comments · Fixed by #5687 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Assignees
@bahmutov
Labels
CI General issues involving running in a CI provider

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Nov 5, 2019

Cypress v3.6.0 on GitHub actions does not send CI name, should also send CI build id (workflow name + SHA)

Typical env variables

GITHUB_ACTION=run1
GITHUB_ACTIONS=true
GITHUB_ACTOR=bahmutov
GITHUB_BASE_REF=master
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_HEAD_REF=add-github-actions
GITHUB_REF=refs/pull/320/merge
GITHUB_REPOSITORY=cypress-io/cypress-example-kitchensink
GITHUB_SHA=d8ab5f0dbc430ee17a1ad2324161a96654b27e9e
GITHUB_WORKFLOW=Cypress tests
GITHUB_WORKSPACE=/home/runner/work/cypress-example-kitchensink/cypress-example-kitchensink

Dashboard view

Screen Shot 2019-11-05 at 10 17 12 AM
@bahmutov bahmutov self-assigned this Nov 5, 2019
@bahmutov bahmutov mentioned this issue Nov 5, 2019
Closed
@bahmutov
Copy link
Contributor Author

Reference https://help.github.com/en/actions/automating-your-workflow-with-github-actions/using-environment-variables#default-environment-variables

@bahmutov bahmutov mentioned this issue Nov 13, 2019
Merged
1 task
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Nov 13, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Nov 15, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 15, 2019

The code for this is done in cypress-io/cypress#5687, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 27, 2019

Released in 3.7.0.

@snyk-bot snyk-bot mentioned this issue Dec 21, 2019
Open
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 2, 2020
@jennifer-shehane jennifer-shehane added CI General issues involving running in a CI provider and removed CI: github actions labels Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bahmutov bahmutov

Labels
CI General issues involving running in a CI provider
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @bahmutov