Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom snapshot iframe placeholder HTML not rendering #5295

Closed
kuceb opened this issue Oct 4, 2019 · 2 comments · Fixed by #5296
Closed

dom snapshot iframe placeholder HTML not rendering #5295

kuceb opened this issue Oct 4, 2019 · 2 comments · Fixed by #5296
Assignees
@kuceb
Labels
type: user experience Improvements needed for UX

Comments

@kuceb
Copy link
Contributor

kuceb commented Oct 4, 2019 •
edited
Loading

  • when viewing dom snapshot, I should see placeholder HTML inside iframe
    problem:
  • something about how inlined data: html changed and cannot handle the # in color: #888

expected:
image

actual:
image

found in:
Cypress 3.4.1 (since unknown)
browsers: chromium 74 on linux

proposed solution:

switch to base64 encoding and use btoa(contents) to encode our html
@kuceb kuceb added the type: user experience Improvements needed for UX label Oct 4, 2019
@kuceb kuceb mentioned this issue Oct 4, 2019
Merged
1 task
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 4, 2019
@kuceb kuceb self-assigned this Oct 4, 2019
@kuceb kuceb changed the title iframe placeholder HTML not rendering dom snapshot iframe placeholder HTML not rendering Oct 4, 2019
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Oct 8, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 29, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 29, 2019

The code for this is done in cypress-io/cypress#5296, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 29, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2019

Released in 3.6.0.

@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
1 participant
@kuceb