Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit cleanly on renderer crashes and provide an explanation and ramifications #348

Closed
brian-mann opened this issue Dec 16, 2016 · 2 comments
Assignees
Labels
type: unexpected behavior User expected result, but got another
Milestone

Comments

@brian-mann
Copy link
Member

brian-mann commented Dec 16, 2016

It is possible that when running headlessly the renderer crashes. This can be due to a bunch of reasons:

  • memory leaks in Cypress
  • running in a memory starved VM environment
  • running lots of tests on an extremely memory intense application
  • GPU driver conflicts with Chromium
  • your code created an endless loop
  • browser bugs with Chromium

It is therefore impossible to prevent and we must take this into account how to recover.

Currently Cypress exits with a 0 status code which is very, very, very wrong.

The simple fix for this is to add an error explanation, link to an error doc, and exit with a non 0 status.

We also need to finish the underlying cleanup process such as compressing videos, uploading assets, report on this error, etc.

@brian-mann
Copy link
Member Author

Going to go with something like this...

screen shot 2016-12-16 at 10 52 08 pm

@brian-mann
Copy link
Member Author

Fixed in 0.18.3.

@brian-mann brian-mann added this to the 0.18.3 milestone Dec 19, 2016
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: unexpected behavior User expected result, but got another
Projects
None yet
Development

No branches or pull requests

1 participant