Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require and Review Changelog Entries for PRs #25154

Closed
emilyrohrbough opened this issue Dec 14, 2022 · 0 comments · Fixed by #25459
Closed

Require and Review Changelog Entries for PRs #25154

emilyrohrbough opened this issue Dec 14, 2022 · 0 comments · Fixed by #25459
Assignees
Labels
process: build Related to our internal build process

Comments

@emilyrohrbough
Copy link
Member

@emilyrohrbough commented on Tue Sep 20 2022

Require a CHANGELOG entry for Cypress CLI or binary changes. This entry will be added to the “UNRELEASED” section in the ./CHANGELOG.md file and will following the Writing Guidelines specified here.
- Write Script to ensure changelog entry was added
- CI check fails if not added

Impact: Changelog should be 90% of the way “ready” when Cypress app releases are kicked off. Releaser will clean up grammar and add any missing details or links.

Notes:
There is no need to enforce this for for NPM packages at this time. Semantic Release generates this automatically for us from commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process: build Related to our internal build process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant