Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to change spec path before it is created from component #25005

Closed
astone123 opened this issue Dec 6, 2022 · 6 comments
Closed

Allow users to change spec path before it is created from component #25005

astone123 opened this issue Dec 6, 2022 · 6 comments
Labels
stale no activity on this issue for a long period

Comments

@astone123
Copy link
Contributor

astone123 commented Dec 6, 2022

What would you like?

Currently when users create a spec from a component, we auto-generate a file name and path for them. There are some edge cases where this can lead to confusing experiences with specs being placed in an unexpected location or with a confusing spec name.

Before the spec file is created, we should show the "blank spec" modal with the path where we would put the generated spec file and give the user the opportunity to change the path (as long as it conforms to the spec pattern) before proceeding with generating the spec file.

This screen already exists for generating blank specs, so we should be able to re-use the UI for this purpose.

Screen Shot 2022-12-06 at 1 18 45 PM

Screen Shot 2022-12-06 at 1 18 56 PM

@astone123
Copy link
Contributor Author

@lmiller1990
Copy link
Contributor

Can't you already do this? What are the edge cases?

I just tried it out - you choose your component, then you can change the spec path to whatever you like. I don't understand the change - are we just swapping the order of the two steps?

@ZachJW34
Copy link
Contributor

Do we always show the user-editable path after clicking on a component or only when an error occurs when generating a name?

@astone123
Copy link
Contributor Author

@ZachJW34 i think the idea was to always show it

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Jun 19, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale no activity on this issue for a long period
Projects
None yet
Development

No branches or pull requests

4 participants