-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom reporter and experimentalSessionAndOrigin crashes #24630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at-binary-rather-than-monorepo
…at-binary-rather-than-monorepo
Thanks for taking the time to open a PR!
|
emilyrohrbough
approved these changes
Nov 9, 2022
mjhenkes
approved these changes
Nov 9, 2022
This was referenced Nov 9, 2022
ZachJW34
approved these changes
Nov 10, 2022
ryanthemanuel
changed the title
fix: improve binary cleanup to look at binary rather than monorepo
fix: custom reporter and experimentalSessionAndOrigin crashes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress run
->Error: Cannot find module 'mocha-7.0.1'
#24607v11.0.0
Broken withexperimentalSessionAndOrigin: true
#24611User facing changelog
Cypress will no longer crash when using a third party reporter like
mochawesome
.Cypress will no longer crash when using the
experimentalSessionAndOrigin
flag.Cypress will now refresh and rerun CT tests when they are modified and saved.
Additional details
When cleaning up the binary due to the v8 snapshot work, there were a couple of dependencies that were removed that shouldn't have been.
In the case of third party mocha reporters, we do some swizzling at runtime with a hard coded version of mocha (mocha-7.0.1). In order to allow this to work properly, we need to leave
mocha-7.0.1
in the binary.In the case of the
experimentalSessionAndOrigin
flag, we have a dynamically loaded loader whose dependencies were not being flagged as something that shouldn't be removed. We will ensure that these dependencies are kept by wrapping this dependency in arequire.resolve
.For the CT test issue, we needed to flag a dependency as
norewrite
manually.Steps to test
Run the binary with a third party reporter like
mochaawesome
Run the binary with
experimentalSessionAndOrigin
turned onHow has the user experience changed?
The app no longer crashes in the above scenarios.
PR Tasks
cypress-documentation
?type definitions
?