Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue #21643

Closed
vasal635 opened this issue May 26, 2022 · 6 comments
Closed

Performance issue #21643

vasal635 opened this issue May 26, 2022 · 6 comments
Assignees
Labels
stage: investigating Someone from Cypress is looking into this

Comments

@vasal635
Copy link

Current behavior

I checked cypress performance on version 9.7.0 and this is slower then 8.1.0

MacOs Monterey 12.4 (21F79)
MacBook Pro (16-inch, 2019)
Processor 2,6 GHz 6-Core Intel Core i7
Memory 16 GB 2667 MHz DDR4

I used the same test for 2 versions.

In version 9.7.0 it's taking average 130 seconds per my test.

Screenshot 2022-05-24 at 11 22 52

In version 8.1.0 it's taking average 70 seconds per my test.

Screenshot 2022-05-24 at 11 19 02

Desired behavior

I'm waiting, that new version will have better performance, then old one.

Also I tried to install new versions for several times -> but performance was bad.

Test code to reproduce

  1. Install version 8.1.0
    npm install --save-dev [email protected]

  2. Run test and make screenshot of time

  3. Install version 9.7.0
    npm install --save-dev [email protected]

  4. Run test and make screenshot of time

  5. Notice, that new version is slower, then old one

Cypress Version

9.7.0

Other

No response

@vasal635 vasal635 changed the title Performance issue p Performance issue May 26, 2022
@cypress-bot cypress-bot bot added stage: internal stage: investigating Someone from Cypress is looking into this and removed stage: internal labels May 26, 2022
@bbartizek
Copy link

bbartizek commented May 26, 2022

I noticed similar results. We have a test suite in one of our CI pipelines that averages 12m 10s over the last 30 days on 8.1.0. I recently upgraded to 9.7.0 in order to take advantage of the new experimental session() feature, and the same suite with only minor changes for the session handling went to ~25 minutes. I thought it was due to the new session behavior compared to inheriting existing sessions between tests, but that seemed like a huge hit for just fetching browser state from cache. I think my results might be impacted in the same way as vasal365.

Edit: Median test duration went from 3 seconds on 8.1.0 to 9 seconds on 9.7.0

@romankhomitskyi
Copy link

Same here, tests are really slow on 9.5.0
It would be great if this issue got fixed before 10 release

@darrinmn9
Copy link

possibly related to #18564 ?

@ZachJW34
Copy link
Contributor

ZachJW34 commented Jun 1, 2022

As @darrinmn9 pointed out, we have an existing issue for performance that matches a subset of the versions you listed. Can you try testing your application with version 8.3.0 and 8.6.0 and see if the slowdown is caused from that upgrade? Also, a reproduction would be very helpful.

If there are no performance problems for versions after 8.6, I'm going to close this as a duplicate of #18564.

@bbartizek If your issues are due to the new experimental session support, can you open a new issue? Depending on how you refactored your tests there might be cause for the slowdown. A reproduction of what you are seeing would be helpful, otherwise it is hard to pinpoint what might be causing the slowdowns.

@vasal635
Copy link
Author

vasal635 commented Jun 2, 2022

Hi @ZachJW34

Yes, this is duplicate of #18564

I have a lot of cy.visit() in this tests.

I also tried 10.0.1
Screenshot 2022-06-02 at 11 47 43

But 8.1.0 still has better performance
Screenshot 2022-06-02 at 11 35 28

Hope, that you will fix it.

@mjhenkes
Copy link
Member

mjhenkes commented Jun 2, 2022

Closing as duplicate of #18564

@mjhenkes mjhenkes closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage: investigating Someone from Cypress is looking into this
Projects
None yet
Development

No branches or pull requests

6 participants