Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure screenshots can randomly not show runner UI if there's a screenshot in the test #1765

Closed
chrisbreiding opened this issue May 24, 2018 · 2 comments
Closed

Failure screenshots can randomly not show runner UI if there's a screenshot in the test #1765

chrisbreiding opened this issue May 24, 2018 · 2 comments
Assignees
@chrisbreiding
Labels
pkg/server This is due to an issue in the packages/server directory type: bug
Milestone
3.0.0

Comments

@chrisbreiding
Copy link
Contributor

Currently, failure screenshots bypass the pixel-checking we do on regular screenshots for the sake of speed. In most cases, this is fine since most tests aren't going to have screenshots in them. However, in the case of a test having a cy.screenshot() command in it and failing, the failure screenshot can randomly not display the runner UI because the browser hasn't had time to paint it yet.

I think we need to re-introduce the pixel-checking on failure screenshots to make them 100% reliable. This, of course, will add some latency to them.
@chrisbreiding chrisbreiding added type: bug pkg/server This is due to an issue in the packages/server directory labels May 24, 2018
@chrisbreiding chrisbreiding added this to the 3.0.0 milestone May 24, 2018
@chrisbreiding chrisbreiding self-assigned this May 24, 2018
@chrisbreiding
Copy link
Contributor Author

It's possible to keep track of whether a screenshot is taken in a test and only do the pixel-checking on failures in that case only. So for the majority use-case, there will be no added latency.

This was referenced May 24, 2018
Closed
Merged
@jennifer-shehane jennifer-shehane added the stage: needs review The PR code is done & tested, needs review label May 24, 2018
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 25, 2018
@brian-mann
Copy link
Member

Released in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbreiding chrisbreiding

Labels
pkg/server This is due to an issue in the packages/server directory type: bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@chrisbreiding @brian-mann @jennifer-shehane