fix: prevent vite from crashing where there are no support files or specs found #17624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no values, in the optimization array, supportFile can be a boolean. the final optimized entry passed to fast-glog is then `[false]` whic crashes cypress. This protects against the no-spec issue closes #17373
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
JessicaSachs
changed the title
JessicaSachs
reviewed
Aug 5, 2021
| @@ -59,7 +59,9 @@ const resolveServerConfig = async ({ viteConfig, options }: StartDevServerOption | |||
| // Ask vite to pre-optimize all dependencies of the specs | |||
| finalConfig.optimizeDeps = finalConfig.optimizeDeps || {} | |||
|
|
|||
| finalConfig.optimizeDeps.entries = [...options.specs.map((spec) => spec.relative), supportFile] | |||
| if (options.specs.length || supportFile) { | |||
There was a problem hiding this comment.
Should probably make sure that if specs is undefined, make sure that we don't crash.
There was a problem hiding this comment.
OK I'll add this protection
ewagoner
approved these changes
Aug 6, 2021
JessicaSachs
approved these changes
Aug 6, 2021
elevatebart
pushed a commit
that referenced
this pull request
Aug 6, 2021
…pecs found (#17624) * fix: no supportfile + no specs, vite don't crash When there is no values, in the optimization array, supportFile can be a boolean. the final optimized entry passed to fast-glog is then `[false]` whic crashes cypress. This protects against the no-spec issue closes #17373 * fix: protect startServer from undefined specs
elevatebart
pushed a commit
that referenced
this pull request
Aug 10, 2021
#17641) * fix: prevent vite from crashing where there are no support files or specs found (#17624) * fix: no supportfile + no specs, vite don't crash When there is no values, in the optimization array, supportFile can be a boolean. the final optimized entry passed to fast-glog is then `[false]` whic crashes cypress. This protects against the no-spec issue closes #17373 * fix: protect startServer from undefined specs * fix: when there are specs but the supportFile is undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no values, in the optimization array,
supportFile can be a boolean. the final optimized entry passed to
fast-glog is then
[false]whic crashes cypress.This protects against the no-spec issue
closes #17373
How to reproduce
yarn create vite-app)yarn create cypress-tests)cypress.jsonsetsupportFiletofalseand make sure there is no spec files.Here is the crash.