fix(vite-dev-server): conditionally require vue and update alias if installed #16000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
tgriesser
added a commit
that referenced
this pull request
Apr 15, 2021
…io/cypress into tgriesser/fix/3975-redirect-bug * 'tgriesser/fix/3975-redirect-bug' of github.com:cypress-io/cypress: fix(@cypress/webpack-batteries-included-preprocessor): Ensure typescript options are set if typescript path is provided (#15991) chore: release @cypress/vite-dev-server-v1.2.2 fix: conditionally require vue and update alias if installed (#16000) docs: remove cssFiles from the vue documentation (#15971) chore: release @cypress/webpack-dev-server-v1.1.3 chore: release @cypress/vite-dev-server-v1.2.1 chore: release @cypress/react-v5.3.3 fix: remove lazy-compile-webpack-plugin (#15964)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fix a bug where vite dev server requires Vue 3 to be installed, even if you are not using it.
Additional details
Currently we assume Vue 3 is installed. We really should not have any framework specific code here at all, long term, but for now it's the only way to work around some Vite bugs.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?