feat: simplify vite server #15416

elevatebart · 2021-03-11T00:54:54Z

Closes CT-319, CT-245

User facing changelog

On vite dev server,
- make errors display with the proper viewport and with the full power of vite
- Add support for testing library (global was missing)
- Fixed support for vite plugins
- Fixed support for loading css and images

Additional details

routes-ct: Pass down the original routes with their __cypress/src prefix to the dev-server
vite-dev-server: remove some of the complexity of the import
Use cypress hooks instead of mocha hooks to init each test

How has the user experience changed?

failure-vite-demo.mov

PR Tasks

Have tests been added/updated?
Has the original issue or this PR been tagged with a release in ZenHub?

cypress-bot · 2021-03-11T00:54:56Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

lmiller1990

I have many questions about this PR, but nice job implementing the hooks!

lmiller1990 · 2021-03-11T00:58:03Z

npm/vite-dev-server/index-template.html

@@ -58,12 +29,6 @@
      Cypress.onSpecWindow(window, importsToLoad)
      Cypress.action('app:window:before:load', window)

-      before(() => {


I am sure we need this - please try running a spec with multiple it blocks that mount a React component. One called react-no-jsx.spec.tsx.

It's possible we don't!

Tests in this spec are passing, both in CI and in open mode.

Actually scratch that, they only work on open, not in CI...

Bizarre

Better fix that before merging, can help out if needed

npm/vite-dev-server/index-template.html

cypress · 2021-03-12T21:50:19Z

Test summary

9392 • 0 • 119 • 3 • 1

Run details


Project	cypress
Status	Passed
Commit	`a75f168`
Started	Mar 31, 2021 4:04 PM
Ended	Mar 31, 2021 4:16 PM
Duration	11:45 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

Flakiness

	cypress/integration/retries.ui.spec.js		1
1	runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

JessicaSachs · 2021-03-18T05:31:31Z

I'm unable to test this... it's still erroring.

JessicaSachs · 2021-03-21T05:44:33Z

I picked up Chakra's new Vite impl and tested it out. It's failing with a new kind of dependency optimization error.

Here's a link to the branch/fork

lmiller1990 reviewed Mar 11, 2021

View reviewed changes

elevatebart added 5 commits March 12, 2021 14:38

feat: simplify vite server

5c3c184

fix: make CI work

1b1a67b

remove weird changes

a8331e5

wip: try error management

fcaba49

fix: fill in mime types

f98a0af

elevatebart force-pushed the feat/vite-error-management branch from 43aa4b9 to f98a0af Compare March 12, 2021 21:29

elevatebart and others added 15 commits March 13, 2021 11:49

Merge branch 'develop' into feat/vite-error-management

42344b9

fix: update version of vite

c456dde

fix: make styles work

2cc136e

adjusting for vue 3 tests too

493eed3

make vue & react work

7ad993b

remove bad option

39c7e53

refactor: simplify url forwarding

31c7215

fix: use vite server to transform html

905fa6b

Merge branch 'develop' into feat/vite-error-management

aa6494d

rollback unwanted changes

d052125

display errors correctly

db83700

Merge branch 'develop' into feat/vite-error-management

9f81b72

reactor: move some files around

f67e60d

rename file typo

26d59c9

fix comments

db59ff9

lmiller1990 previously approved these changes Mar 19, 2021

View reviewed changes

elevatebart added 4 commits March 18, 2021 20:56

Merge branch 'develop' into feat/vite-error-management

57cd0da

build: report vite tests on circle

6763db6

fix: vite client for specs

ca4f052

tests: add vue support file

736e738

elevatebart added 3 commits March 20, 2021 18:36

fix design system quirks

9d8c5b8

fix: delay async component to make tets more stable

107c9a4

adapt rollup dev server to new architecture

bdc3a18

lmiller1990 self-requested a review March 22, 2021 15:28

elevatebart added 19 commits March 22, 2021 10:31

remove hacks since they don't work

2c07d5a

Merge branch 'develop' into feat/vite-error-management

c74dcdd

fix: load normally

1b3c956

update vitejs

e3d01ce

avoid need to hae an html file at root

0345ca3

Merge branch 'develop' into feat/vite-error-management

ebd5fea

publish html file

88d0815

fix vite server

f73aae6

fix: avoid error when vite cannot annalyze pure dynamic dependency

f6c8786

add an extra vue spec

5c33498

store videos in ci

63ee608

videos path update

1b74f7f

remove data-cy

6b15fc7

reorder tests to see if they pass

25d9a89

Merge branch 'develop' into feat/vite-error-management

937f04c

use vue3 as a showcase

86a3b85

make a local version of vue 2

215b722

remove unnecessary change

65bfa76

Merge branch 'develop' into feat/vite-error-management

b85c2a8

elevatebart requested a review from JessicaSachs March 31, 2021 15:47

JessicaSachs approved these changes Mar 31, 2021

View reviewed changes

Merge branch 'develop' into feat/vite-error-management

a75f168

elevatebart merged commit adc2fc8 into develop Mar 31, 2021

elevatebart deleted the feat/vite-error-management branch March 31, 2021 16:16

elevatebart pushed a commit that referenced this pull request Apr 2, 2021

feat: simplify vite server (#15416)

86276b9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: simplify vite server #15416

feat: simplify vite server #15416

elevatebart commented Mar 11, 2021 •

edited

Loading

cypress-bot bot commented Mar 11, 2021

lmiller1990 left a comment

lmiller1990 Mar 11, 2021

lmiller1990 Mar 11, 2021

elevatebart Mar 11, 2021

elevatebart Mar 11, 2021

lmiller1990 Mar 11, 2021

cypress bot commented Mar 12, 2021 •

edited

Loading

JessicaSachs commented Mar 18, 2021

JessicaSachs commented Mar 21, 2021

feat: simplify vite server #15416

feat: simplify vite server #15416

Conversation

elevatebart commented Mar 11, 2021 • edited Loading

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

cypress-bot bot commented Mar 11, 2021

lmiller1990 left a comment

Choose a reason for hiding this comment

lmiller1990 Mar 11, 2021

Choose a reason for hiding this comment

lmiller1990 Mar 11, 2021

Choose a reason for hiding this comment

elevatebart Mar 11, 2021

Choose a reason for hiding this comment

elevatebart Mar 11, 2021

Choose a reason for hiding this comment

lmiller1990 Mar 11, 2021

Choose a reason for hiding this comment

cypress bot commented Mar 12, 2021 • edited Loading

Test summary

Run details

Flakiness

JessicaSachs commented Mar 18, 2021

JessicaSachs commented Mar 21, 2021

elevatebart commented Mar 11, 2021 •

edited

Loading

cypress bot commented Mar 12, 2021 •

edited

Loading