The its command doesn't accept a log option (logging can't be disabled)

[cwohlman]

Current behavior:

cy.window({ log: false }).its('something', { log: false }) throws an error because no options object is supported. (The docs bear this out as well).

Desired behavior:

I should be able to suppress logging using its('something', { log: false }) or the its command should inherit the log level from the previous call (if this is currently the expected behavior I'll investigate further and create a reproduction, I didn't see a mention of this in the docs).

Also, I would think that the its command should accept a timeout property.

• Cypress Version: 2.1.0

[brian-mann]

Agree. Oversight on our part.

[jennifer-shehane]

We are open source and welcome contributions, even a 'work in progress' PR is helpful!

.its() and .invoke() both call into this invokeFn: https://github.com/cypress-io/cypress/blob/issue-1350/packages/driver/src/cy/commands/connectors.coffee#L124

You can see there is the log directly after it: https://github.com/cypress-io/cypress/blob/issue-1350/packages/driver/src/cy/commands/connectors.coffee#L138

Here is an example of accepting the log option and using it to log or not, for reference: https://github.com/cypress-io/cypress/blob/issue-1350/packages/driver/src/cy/commands/querying.coffee#L30

We would also need some tests around this new behavior for its and invoke

[cwohlman]

How do we deal with the arguments spread operator for invoke?

[bahmutov]

Also needs timeout option, just like other commands

[wildaces215]

Is this open?

[wildaces215]

I would like handle it!

[jennifer-shehane]

@wildaces215 There has been no work done on this issue. Feel free to open a pull request.

[simonhaenisch]

I also need this, but don't have any coffeescript experience :|

Is it that invokeFn = (subject, fn, args...) -> needs to be changed to

invokeFn = (subject, fn, options = { log: true }, args...) ->

and then replace options._log = Cypress.log with

if options.log
  options._log = Cypress.log

?

Or do you rather use

_.defaults(options, {
  log: true
})

instead of function argument defaults?

Update: I actually don't really need this... in my custom command, instead of cy.request().its('body').then(body => ...) I just do cy.request().then(res => res.body ...).

Tried installing cypress on my machine to work on this, but the npm install failed with EINTEGRITY in the static package (maybe because I'm running node v8.11.2 not v.8.2.1).

[gabbersepp]

I will take this one

[gabbersepp]

At a first step I added the Loggable options to its(). I will try a variant for invoke() in the next days
//Edit: added an option argument but had to add this as first parameter to decide if it is of type Loggable or belong to the arguments of the function call

[gabbersepp]

I will have a look at the timeout requirement now

[gabbersepp]

What would be the case for a timeout here? Is it a common use case that an existing object is extended with properties or functions after some time?

[cypress-bot]

The code for this is done in cypress-io/cypress#5519, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.8.0.