fix(commands.type): Fix the .type command on an input of type n… (#6121)

Fix edge case introduced into #6033 about typing invalid number Fixes #6055 Co-authored-by: Jennifer Shehane <[email protected]>
cypress-io · Jan 10, 2020 · a76b3b6 · a76b3b6 · cypress-bot · Jan 10, 2020
1 parent 957d76a
commit a76b3b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/driver/src/cy/keyboard.ts b/packages/driver/src/cy/keyboard.ts
@@ -263,7 +263,8 @@ const shouldUpdateValue = (el: HTMLElement, key: KeyDetails, options) => {
         debug('skipping inserting value since number input would be invalid', key.text, potentialValue)
         // when typing in a number input, only certain whitelisted chars will insert text
         if (!key.text.match(isValidNumberInputChar)) {
-          options.prevVal = ''
+          // https://github.com/cypress-io/cypress/issues/6055
+          // Should not remove old valid values when a new one is not a valid number char, just dismiss it with return
 
           return
         }

diff --git a/packages/driver/test/cypress/integration/commands/actions/type_spec.js b/packages/driver/test/cypress/integration/commands/actions/type_spec.js
@@ -1252,6 +1252,13 @@ describe('src/cy/commands/actions/type', () => {
           .should('have.value', '-123.12')
         })
 
+        // https://github.com/cypress-io/cypress/issues/6055
+        it('can type negative numbers and dismiss invalid characters', () => {
+          cy.get('#number-without-value')
+          .type('-a42')
+          .should('have.value', '-42')
+        })
+
         it('can type {del}', () => {
           cy.get('#number-with-value')
           .type('{selectAll}{del}')