Skip to content

Commit

Permalink
fix: Revert "chore: set rejectUnauthorized for api calls (#24087)" (#…
Browse files Browse the repository at this point in the history
…24370)

This reverts commit d9c5e57.
  • Loading branch information
mschile authored Oct 24, 2022
1 parent 8ab3ea8 commit 851552c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion packages/server/lib/cloud/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ const rp = request.defaults((params, callback) => {
proxy: null,
gzip: true,
cacheable: false,
rejectUnauthorized: true,
})

const headers = params.headers != null ? params.headers : (params.headers = {})
Expand Down
14 changes: 0 additions & 14 deletions packages/server/test/unit/cloud/api_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,20 +69,6 @@ describe('lib/cloud/api', () => {
})
})

it('sets rejectUnauthorized on the request', () => {
nock.cleanAll()

return api.ping()
.thenThrow()
.catch(() => {
expect(agent.addRequest).to.be.calledOnce

expect(agent.addRequest).to.be.calledWithMatch(sinon.match.any, {
rejectUnauthorized: true,
})
})
})

context('with a proxy defined', () => {
beforeEach(function () {
nock.cleanAll()
Expand Down

5 comments on commit 851552c

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 851552c Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.0/linux-x64/develop-851552cebdb327d52415180744757e4468a65aae/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 851552c Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.0/linux-arm64/develop-851552cebdb327d52415180744757e4468a65aae/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 851552c Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.0/darwin-x64/develop-851552cebdb327d52415180744757e4468a65aae/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 851552c Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.0/darwin-arm64/develop-851552cebdb327d52415180744757e4468a65aae/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 851552c Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.0/win32-x64/develop-851552cebdb327d52415180744757e4468a65aae/cypress.tgz

Please sign in to comment.