From 77b362e4ccb09004a834d4e5707ca5e229812333 Mon Sep 17 00:00:00 2001 From: Gleb Bahmutov Date: Wed, 4 Dec 2019 16:29:04 -0500 Subject: [PATCH] build and test on Mac --- circle.yml | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/circle.yml b/circle.yml index 3af695a15b69..23d86cfd347e 100644 --- a/circle.yml +++ b/circle.yml @@ -19,6 +19,16 @@ defaults: &defaults COLUMNS: 100 LINES: 24 +# usually we don't build Mac app - it takes a long time +# but sometimes we want to really confirm we are doing the right thing +# so just add your branch to the list here to build and test on Mac +macBuildFilters: &macBuildFilters + filters: + branches: + only: + - develop + - electron-upgrade + executors: # the Docker image with Cypress dependencies and Chrome browser cy-doc: @@ -1118,20 +1128,14 @@ mac-workflow: &mac-workflow - build: name: Mac build executor: mac - filters: - branches: - only: - - develop + <<: *macBuildFilters - lint: name: Mac lint executor: mac + <<: *macBuildFilters requires: - Mac build - filters: - branches: - only: - - develop # maybe run unit tests? @@ -1160,10 +1164,7 @@ mac-workflow: &mac-workflow name: Mac binary context: org-global executor: mac - filters: - branches: - only: - - develop + <<: *macBuildFilters requires: - Mac build @@ -1181,10 +1182,7 @@ mac-workflow: &mac-workflow - test-kitchensink: name: Test Mac Kitchensink executor: mac - filters: - branches: - only: - - develop + <<: *macBuildFilters requires: - Mac build