diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 450aa6a6d7..49dfc34350 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -79,7 +79,7 @@ If you need to release alternate versions that do not qualify to be primary vers 1. Create a feature branch in the form `-node--publish`, for example `13.11.0-node-18.20.3-publish`, branched from the `master` branch. If you are not a member of the Cypress org, make a request via a new issue to create a feature branch. 2. Modify [factory/.env](./factory/.env) with the desired versions. Do not modify the `FACTORY_VERSION`. No new `cypress/factory` image should be published with this process. -3. Modify [factory/docker-compose.yml](./factory/docker-compose.yml) to comment out the creation of `latest` tags. Comment out the `cypress/browsers` `BROWSERS_IMAGE_SHORT_TAG` and `cypress/included` `INCLUDED_IMAGE_SHORT_TAG` to also prevent these tags from being created. This step is essential to avoid the related tags of any existing released images being moved to point to non-primary images. +3. Modify [factory/docker-compose.yml](./factory/docker-compose.yml) to comment out the creation of `latest` tags. Comment out the `cypress/included` `INCLUDED_IMAGE_SHORT_TAG` to also prevent this tag from being created. This step is essential to avoid the related tags of any existing released images being moved to point to non-primary images. 4. Modify [circle.yml](circle.yml) to push releases from the feature branch. 5. Open a PR which targets the feature branch. 6. After PR merge, check Docker Hub and the associated new image(s). diff --git a/factory/docker-compose.yml b/factory/docker-compose.yml index 8aece83027..4f73a2a101 100644 --- a/factory/docker-compose.yml +++ b/factory/docker-compose.yml @@ -55,7 +55,7 @@ services: EDGE_VERSION: ${EDGE_VERSION} tags: - ${REPO_PREFIX-}cypress/browsers:latest # comment out for release of alternate version - - ${REPO_PREFIX-}cypress/browsers:${BROWSERS_IMAGE_SHORT_TAG} # comment out for release of alternate version + - ${REPO_PREFIX-}cypress/browsers:${BROWSERS_IMAGE_SHORT_TAG} - ${REPO_PREFIX-}cypress/browsers:${BROWSERS_IMAGE_TAG} command: node -v