Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set circleci_ip_ranges to use known IP ranges #356

Open
rickythefox opened this issue Jul 30, 2021 · 8 comments
Open

Allow to set circleci_ip_ranges to use known IP ranges #356

rickythefox opened this issue Jul 30, 2021 · 8 comments
Labels
type: enhancement New feature or request

Comments

@rickythefox
Copy link

CircleCI now provides a flag for using known IP ranges. This can be helpful when testing firewalled environments, e.g. staging environments. See https://circleci.com/docs/2.0/ip-ranges/. This is achieved by setting circleci_ip_ranges: true on the job.

My feature request is to enable this in the orb as an optional setting.

I can submit a PR if this is of interest.

@arvid-m
Copy link

arvid-m commented Sep 6, 2021

This feature would be very useful! It's currently blocking us from using the orb.

@vcmuner
Copy link

vcmuner commented Nov 11, 2021

would be very useful indeed, I'm about to stop using the orb because of this

@Zach-Costa
Copy link

Is this still in progress? My team is looking to get this implemented for our runs, but we'd like to keep using the orb if possible.

@chiraggshah
Copy link

I would like to use this, but there seem to be no updates.

@jennifer-shehane
Copy link
Member

I believe passing CircleCI params to the orb should work. Please try upgrading to v3.0.0 of the orb. Please comment if this is still occuring.

@rickythefox
Copy link
Author

Just realised I solved this problem in a different way and forgot my offer to submit a PR. It still stands if v3.0.0 does not solve the issue.

@james-luther
Copy link

I'm having this issue currently and am not sure how to pass this param to the orb. I am using an anchor to define the job and not able to pass it correctly. I'm not sure if this is just unsupported or if there is a syntax error. I'm receiving Unexpected argument(s): circleci_ip_ranges

@tmannherz
Copy link

You can't pass circleci_ip_ranges to the cypress/run job (it'll throw the Unexpected argument... error) but instead would need to explicitly define your own jobs that call the same commands as cypress/run:

version: 2.1
orbs:
  cypress: cypress-io/[email protected]
jobs:
  run:
    executor: cypress/default
    circleci_ip_ranges: true
    steps:
      - cypress/install:
          working-directory: ./
      - cypress/run-tests:
          working-directory: ./
workflows:
  run-tests:
    jobs:
      - run

@jennifer-shehane jennifer-shehane added the type: enhancement New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants