Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefetching in range mode with args #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lukasbesch
Copy link
Contributor

@lukasbesch lukasbesch commented Jun 29, 2020

Prefetching in range mode with args() has the issue that opts.page is NaN on the prefetched call of the fetchPage() function.
I wrote a failing test and a fix, but the test does not succeed yet.
The example seems to be working though.

For the test:
I think another call of nextTick() is necessary (before changing pageTo) to allow the second promise to resolve.
But that alone does not work yet.

@lukasbesch lukasbesch marked this pull request as ready for review June 29, 2020 15:28
@MaxGfeller
Copy link
Contributor

Thanks for the pull request - and sorry for the delay! I added a few await nextTick() where it's neccessary, but there seems to be a different error now. Could you look into that @lukasbesch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants