Fix prefetching in range mode with args #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefetching in range mode with
args()
has the issue thatopts.page
isNaN
on the prefetched call of thefetchPage()
function.I wrote a failing test and a fix, but the test does not succeed yet.
The example seems to be working though.
For the test:
I think another call of
nextTick()
is necessary (before changingpageTo
) to allow the second promise to resolve.But that alone does not work yet.