Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert destructive CI-Commit #267

Closed
TSchiefer opened this issue Feb 6, 2020 · 7 comments
Closed

revert destructive CI-Commit #267

TSchiefer opened this issue Feb 6, 2020 · 7 comments
Assignees
@krlmlr

Comments

@TSchiefer
Copy link
Member

The Auto-Commit: 86078d6 is bugged and I am not sure what causes it. Basically {dm} cannot even be installed in the current state.
@krlmlr
Copy link
Collaborator

krlmlr commented Feb 6, 2020

Tried to revert, let's wait for the build.

I suspect this is caused by styler: https://travis-ci.org/krlmlr/dm/jobs/646859095#L941.

@krlmlr krlmlr closed this as completed in 865380e Feb 6, 2020
@lorenzwalthert
Copy link

OMG! Is that dev styler or the CRAN release?

@krlmlr
Copy link
Collaborator

krlmlr commented Feb 6, 2020

dev, only happens since today I think.

@lorenzwalthert
Copy link

lorenzwalthert commented Feb 6, 2020 •
edited
Loading

Its related to the new caching feature I think. r-lib/styler#578. Investigating. This is a big thing. Thanks for reporting! I did not do sufficient tests then.

@lorenzwalthert lorenzwalthert mentioned this issue Feb 6, 2020
Closed
@lorenzwalthert
Copy link

lorenzwalthert commented Feb 7, 2020 •
edited
Loading

It's resolved in r-lib/styler#585. I successfully styled {dm} with the devel version of styler. Should we turn on styler support again?

@lorenzwalthert
Copy link

lorenzwalthert commented Mar 1, 2020 •
edited
Loading

All things resolved in CRAN version v1.3.2.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@krlmlr krlmlr

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krlmlr @lorenzwalthert @TSchiefer