Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc vr bug with initial cycle point = now #6262

Closed
hjoliver opened this issue Jul 25, 2024 · 2 comments · Fixed by #6316
Closed

cylc vr bug with initial cycle point = now #6262

hjoliver opened this issue Jul 25, 2024 · 2 comments · Fixed by #6316
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@hjoliver
Copy link
Member

[scheduling]
    initial cycle point = now
    [[graph]]
        PT1M = "foo"
[runtime]
    [[foo]]
  1. cylc vip bug
  2. cylc stop bug
  3. (add a comment to flow.cylc)
  4. cylc vr bug

Result:

ERROR - Workflow shutting down - InputError: option --icp is not valid for restart

This only happens for initial cycle point = now 🤔

@hjoliver hjoliver added the bug Something is wrong :( label Jul 25, 2024
@hjoliver hjoliver added this to the 8.3.x milestone Jul 25, 2024
@wxtim wxtim self-assigned this Aug 1, 2024
@wxtim
Copy link
Member

wxtim commented Aug 1, 2024

Duplicated, and assured myself that this is a VR bug - doing this serially as cylc install and then cylc play is fine.

@wxtim
Copy link
Member

wxtim commented Aug 22, 2024

The problem is that the validate step alters the options object passed to it by storing the value of now as options.icp.

I can fix this problem (and any others like it) by copying the options passed to validate, but I wonder if I should stop validate changing options and check that it's not doing this elsewhere?

@oliver-sanders oliver-sanders modified the milestones: 8.3.x, 8.3.4 Aug 27, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.3.4, 8.3.5 Sep 11, 2024
@wxtim wxtim closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants