Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate core logic to terraform-plugin-sdk/v2 #151

Closed
xescugc opened this issue Nov 26, 2020 · 1 comment · Fixed by #186
Closed

Migrate core logic to terraform-plugin-sdk/v2 #151

xescugc opened this issue Nov 26, 2020 · 1 comment · Fixed by #186
Assignees
Labels

Comments

@xescugc
Copy link
Member

xescugc commented Nov 26, 2020

Abstract

The core logic to import is based on the internal code of Terraform before the TF-SDK came out. Now with the TF-SDK beeing more evolved I think we'll be able to use it to move more logic outside of Terracognita into the TF-SDK.

Proposal

Migrate the core logic to TF-SDKv2 so we are not stuck

Implementation

The main idea would be to kind of fake a server initialization using directly the Plugins. Normally how TF works is a GRPC communication between TF and the Providers, if what I'm saying is correct we should be able to initialize in code the TFProvider server and call it manually inside code without GRPC directly.

This is more or less what we are doing now but manually without any TF code in between, but with this change we would need to maintain less code as it'll be maintained by the TF-SDK directly.

All this said this is still a theory but we need to migrate to it somehow because we cannot use TF-SDKv2 internally as they have changed the imports path on the Providers to not use TF anymore but TF-SDKv2 and other changes, so we would be blocked.

Open issues (if applicable)

@xescugc xescugc added the Feature roadmap feature label Nov 26, 2020
@xescugc xescugc self-assigned this Dec 2, 2020
@xescugc
Copy link
Member Author

xescugc commented Jan 4, 2021

Right now this is blocked by hashicorp/terraform-provider-azurerm#10022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant