Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some uses of type number when integer seems more apt. #69

Open
naturalethic opened this issue Apr 27, 2023 · 1 comment
Open

Some uses of type number when integer seems more apt. #69

naturalethic opened this issue Apr 27, 2023 · 1 comment

Comments

@naturalethic
Copy link
Collaborator

For example:

cpu_cores:
    type: number
    description: The number of CPU Cores availiable for builds

In rust, at least, number is interpreted as a float.

In any case, I believe number should eschewed in favor of more explicit float or integer types.

@mattoni
Copy link
Member

mattoni commented Apr 29, 2023

I agree. I'll fix those when I stumble on them or when I have some time to do a clean sweep. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants