add support for specifying revisionHistoryLimit for the generated Certificate #104
+65
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, contour-plus creates Certificates without setting
.spec.revisionHistoryLimit. As a result, the number of CertificateRequests is unbounded and will keep increasing as existing Certificates are renewed or updated. In a long-lived cluster with a lot of HTTPProxies relying on contour-plus, this will lead to a large amount of unnecessary CertificateRequests being kept around.This PR adds support for specifying the upper-bound for the number of CertificateRequests kept per Certificate, allowing cert-manager to perform garbage-collection on older CertificateRequests and keeping things tidy.