Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Incoming Call shows default caller name, not the callerId I specified in TWIML #202

Open
soapthepro opened this issue Nov 17, 2023 · 8 comments
Assignees

Comments

@soapthepro
Copy link

Whenever I am receiving an incoming call, the notification shows the default caller name that I have set using the .defaultCaller function of twilio_voice package. I have verified that I am specifying the callerId as client:abcd in my twiml but still I am not sure why I am seeing this default caller name. Any help will be appreciated.

@cybex-dev
Copy link
Owner

Whenever I am receiving an incoming call, the notification shows the default caller name that I have set using the .defaultCaller function of twilio_voice package. I have verified that I am specifying the callerId as client:abcd in my twiml but still I am not sure why I am seeing this default caller name. Any help will be appreciated.

Hi @soapthepro

Thanks for reporting this issue.

When receiving a call, a notification message is sent to twilio_voice with the CallEvent.ringing. If you are using client:abcd, please confirm the from field containing abcd.

The (old) flow implemented in iOS to grab the caller name is as follows (see here for code):

  1. Saved clients (from registerClient)
  2. Saved Default Caller name e.g. "Twilio Caller"
  3. Default caller if non set, "Unknown Caller"

On a side note, Call Parameter interpretation hasn't been implemented in macOS, iOS yet - this is on the schedule.

@soapthepro
Copy link
Author

Hi @cybex-dev,

I guess I have everything setup correctly, I am able to see the 'from' parameter in my twilio console set to client:abcd. I tried to use a normal number in place of client: caller id and that doesn't work either. Also I noticed that for missed call notification I am receiving notification_missed_call written in the notification.

@cybex-dev
Copy link
Owner

Hi @cybex-dev,

I guess I have everything setup correctly, I am able to see the 'from' parameter in my twilio console set to client:abcd. I tried to use a normal number in place of client: caller id and that doesn't work either.

With regards to the from parameter, could you please confirm if the ActiveCall.from contains the correct user Id.

As a reference, see this.

Also I noticed that for missed call notification I am receiving notification_missed_call written in the notification.

It seems some localization strings resources are missing, see this.

@soapthepro
Copy link
Author

soapthepro commented Nov 17, 2023

@cybex-dev I am not able to receive incoming calls on my device If I directly connect and run a build on it using Xcode, I have to do an internal testing of each build in order to test incoming calls. Can you please help me out how can I check it for incoming calls that I have the from parameter. I am using the callEventsListner and it has a case of case CallEvent.ringing: I guess using this I can get some info but what variable will be having this info? Should I check with TwilioVoice.instance.call.activeCall? in this ringing event

@soapthepro
Copy link
Author

Hey @cybex-dev I tried to print TwilioVoice.instance.call.activeCall.from and I was able to print abcd but the notification showed the default caller name

@soapthepro
Copy link
Author

What can be done in this case @cybex-dev

@zamargab
Copy link

zamargab commented Jan 5, 2024

I am facing the same issue, client calls are displaying default caller name and not the "from" parameter

@bazl-E
Copy link

bazl-E commented Jul 5, 2024

@cybex-dev I am not able to receive incoming calls on my device If I directly connect and run a build on it using Xcode, I have to do an internal testing of each build in order to test incoming calls. Can you please help me out how can I check it for incoming calls that I have the from parameter. I am using the callEventsListner and it has a case of case CallEvent.ringing: I guess using this I can get some info but what variable will be having this info? Should I check with TwilioVoice.instance.call.activeCall? in this ringing event

enable debug mode in Twilio notify service - then you can revice calls on debug mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants