Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences from the paper author's official implementation #10

Open
binmakeswell opened this issue Nov 17, 2020 · 2 comments
Open

Differences from the paper author's official implementation #10

binmakeswell opened this issue Nov 17, 2020 · 2 comments

Comments

@binmakeswell
Copy link

The implementation of the PyTorch version you released is different from the official version of TensorFlow released by the author. According to the official implementation published in the paper, the author's code implementation skips some parameters according to their names when calculating. But in your implementation, it seems that all parameters are directly involved in the calculation.
Their implementation:
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/optimizers/lamb.py

@8enmann
Copy link
Contributor

8enmann commented Nov 17, 2020

Their implementation came out long after I stopped updating this repo. I recommend apex!
https://nvidia.github.io/apex/_modules/apex/optimizers/fused_lamb.html

@shahzad-ali
Copy link

shahzad-ali commented Jan 20, 2022

Their implementation came out long after I stopped updating this repo. I recommend apex! https://nvidia.github.io/apex/_modules/apex/optimizers/fused_lamb.html

First of all, an important line from the official GitHub repo:

Windows support is experimental, and Linux is recommended.

Second, I tried compiling the above repo on Windows that ended with dozens of errors beginning with

C:\Users\USER_NAME\venv-torch181\lib\site-packages\torch\utils\cpp_extension.py:316: UserWarning: Error checking compiler version for cl: [WinError 2] The system cannot find the file specified
warnings.warn(f'Error checking compiler version for {compiler}: {error}')

Is there any workaround (or a recommended alternative)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants