Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are a suite of new generic HTTP connectors #1248

Closed
22 of 41 tasks
izgeri opened this issue Jun 9, 2020 · 4 comments
Closed
22 of 41 tasks

There are a suite of new generic HTTP connectors #1248

izgeri opened this issue Jun 9, 2020 · 4 comments

Comments

@izgeri
Copy link
Contributor

izgeri commented Jun 9, 2020

We currently have a directory for example generic HTTP connector configurations. In this epic, we will create many more.

Our goal is to demonstrate how easy it is to add support for new HTTP-based target services using the generic HTTP connector. You don't even have to write a new Secretless connector! You just structure your configuration so that Secretless knows where to inject the credentials your target service needs, and you can connect to your target service via Secretless with no code changes.

New generic HTTP connector configs to create:

Notes

  • Until work starts on an issue, there will be a TODO in the implementation plan where the engineer who pulls the card will review the target service and determine which authentication methods (if any) may be feasible to implement with the Secretless generic HTTP connector
  • Not all targets in the list above may be possible to implement with the generic HTTP connector.
    • If the engineer reviews the authentication modes of the target service and it's not a good fit for the generic HTTP connector, they'll add notes on the card explaining what's missing.
    • If it looks like adding new functionality to the generic HTTP connector would enable support for the target service, that info will also be added to the card. For example, the Google Maps API supports adding the API key in the URL as a query parameter. At current the generic HTTP connector only supports adding headers, but we could look into adding support for appending query parameters as well.
  • When the engineer creates the generic connector config for the target service, they'll validate it in a local environment. The README in the example dir will provide general high-level instructions for using Secretless with the target, but the pull request that adds the example will have detailed instructions for how the developer demonstrated that the connector works (locally or using their development accounts).
@boazmichaely
Copy link
Contributor

A question came from a customer today asking if we support HTTPS or just HTTP.
There are no stupid questions.. The answer was "yes and here is the link to the https documentation"
So let's make it obvious that HTTPS is supported across the list and in the end blog

@boazmichaely
Copy link
Contributor

For all the use cases, a real life example would be far more powerful than "I'm a developer who needs to connect my app to target X". Trying to find out these real life examples can lead us to real people who would want to try it out

@izgeri
Copy link
Contributor Author

izgeri commented Jun 24, 2020

Added #1286 to reorganize the example dir README

@JakeQuilty
Copy link
Contributor

Updated @izgeri comment to a list to keep track of which ones we've done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants