Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQL Connector faithfully propagates connection parameters from client to target service #1012

Closed
1 of 2 tasks
izgeri opened this issue Nov 22, 2019 · 0 comments
Closed
1 of 2 tasks

Comments

@izgeri
Copy link
Contributor

izgeri commented Nov 22, 2019

The PG and MySQL connectors transparently pass on any parameters passed on by the client in the connection request, and the MSSQL connector needs to be updated to do the same.

Note: credentials, host/port and SSL configuration information are not passed on to the server - they are set by Secretless config.

In this card, you need to read info from the client connection and translate it to the dsn (the data structure that go-mssql uses for connection config)

AC:

  • MSSQL connector passes on any non-credential parameters submitted by the client in the connection request
  • Unit tests exist to ensure the MSSQL connector transparently passes non-credential params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants