Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme has been updated to include Maven instructions #50

Closed
jvanderhoof opened this issue Feb 12, 2020 · 4 comments · Fixed by #71
Closed

Readme has been updated to include Maven instructions #50

jvanderhoof opened this issue Feb 12, 2020 · 4 comments · Fixed by #71
Assignees
@h-artzi
Labels
kind/bug source/salesforce

Comments

@jvanderhoof
Copy link
Contributor

It's come to light that the current Readme is missing instructions to include publication to Maven. Ofira has created a PR (#47) which includes an improvement to the JAR build. What's missing from the Readme is the process of adding the JAR to Maven.

Ofira has graciously added a demo in the conjurdemos/conjur-intro. This includes all the steps required to load the JAR into Maven: https://github.com/conjurdemos/conjur-intro/pull/46/files#diff-604246ad4ac58e848e36bf01aac10f04.

Using @oburstein-hub's branch (OCP_installer_and_java_test) as the base, please add the Maven instructions to the project Readme.
@jvanderhoof
Copy link
Contributor Author

Please reach out to JFC via Slack (@jf christophe) for questions.

@h-artzi
Copy link
Contributor

h-artzi commented Feb 12, 2020

The Maven publication instructions have been added. Please let me know if anything needs to be changed

@jf
Copy link

jf commented Feb 13, 2020

Please reach out to JFC via Slack (@jf christophe) for questions.

eh, no. How am I involved here?

@JfcAtCyberArk
Copy link
Contributor

Please reach out to JFC via Slack (@jf christophe) for questions.

eh, no. How am I involved here?

Sorry, looks like there has been a name conflict between GitHub and Slack :)

@sgnn7 sgnn7 mentioned this issue May 6, 2020
Merged
@sgnn7 sgnn7 closed this as completed in #71 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-artzi h-artzi

Labels
kind/bug source/salesforce
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated readme with various newer information and cleanups cyberark/conjur-api-java
4 participants
@jf @jvanderhoof @h-artzi @JfcAtCyberArk