Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC Authenticator support #54

Open
MTNPCGCG opened this issue Nov 14, 2019 · 3 comments
Open

Add OIDC Authenticator support #54

MTNPCGCG opened this issue Nov 14, 2019 · 3 comments

Comments

@MTNPCGCG
Copy link

Would like to see support for the conjur OIDC provider.

The authenticator shouldn't try to handle OIDC login flows - instead it should just take a ID token. The refresh/login flow should be the concern of code that is invoking this module. It does mean, though, that the authenticator may have be updated with a new ID Token on occasion

@MTNPCGCG
Copy link
Author

It does look the alternate option here is just to implement a separate authenticate call to create a token and store it to a file, then using tokenfile for the client.

@sgnn7
Copy link
Contributor

sgnn7 commented Nov 19, 2019

@MTNPCGCG Your second comment is spot on and it's definitely a desired feature. We do need a way to specify where to find that OIDC token file as the added functionality to support this.

@MTNPCGCG
Copy link
Author

sgnn, I've proposed #55 for this. I actually opted to not to token file backed at present; it's a bit of choice on what approach to take. Since we're wiring this into an application, this is easier. If you were going to use the token file. If someone wants to take a variation of this that does use the token file instead, they're welcome to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants