Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"composer-exit-on-patch-failure": true does not work #170

Closed
AlexSkrypnyk opened this issue Nov 20, 2017 · 3 comments
Closed

"composer-exit-on-patch-failure": true does not work #170

AlexSkrypnyk opened this issue Nov 20, 2017 · 3 comments

Comments

@AlexSkrypnyk
Copy link

AlexSkrypnyk commented Nov 20, 2017

As it has been described in #158, the "composer-exit-on-patch-failure": true in extra is not being picked up.

This applies to 1.6 only. Current master works correctly. Making a release would resolve this.

@danepowell
Copy link
Collaborator

This is fixed in 1.x, as mentioned here: #166

d011661

There shouldn't be anything left to fix here, and there's nothing stopping you from using 1.x-dev, although tagging a new release on 1.x would make it easier to grab.

I'd suggest closing this issue and voicing your concern in #173

@AlexSkrypnyk
Copy link
Author

@danepowell
Using dev version is not a great idea, especially if the project is a boilerplate for other projects. I do not see any reason to not release on each bugfix - that is why we use semantic versioning with a last digit being a patch/fix number.

@cweagans
Copy link
Owner

I do not see any reason to not release on each bugfix

That's really poor release management. I'm not doing that. The last couple of releases were an exception due to high priority bugs.

Additionally, master is probably not what you want to be using anyway. That's eventually going to be 2.x, but it's not ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants