Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated settings for default marking type. #1351

Closed
thomasstats opened this issue Apr 3, 2020 · 1 comment
Closed

Duplicated settings for default marking type. #1351

thomasstats opened this issue Apr 3, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@thomasstats
Copy link

In annotation.html there is

<select id="shapeTypeSelector" class="regular h2"> <option value="box" class="regular" selected> Box </option> <option value="box_by_4_points" class="regular" selected> Box by 4 points </option>

Where both of these items are marked as selected. However, in shapeCreator.js line 235 does the following:

this._typeSelector.val('box');

This creates some redundancy.

@bsekachev bsekachev added the bug Something isn't working label Apr 6, 2020
@bsekachev bsekachev added this to the 1.0.0 - Beta milestone Apr 6, 2020
@bsekachev bsekachev self-assigned this Apr 6, 2020
@bsekachev bsekachev mentioned this issue Apr 6, 2020
6 tasks
@bsekachev
Copy link
Member

Resolved with the PR above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants