-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'probe' does not work under Miri #46
Comments
Ah, turns out we can make this work from the Miri side, so autocfg doesn't need to change anything. :) |
FWIW, that's Cargo suppressing all build script output, unless it's |
Yeah I saw that output. :) (though I think I only passed |
When autocfg is used in the build script of a
cargo miri test
invocation, it recently stopped working.It used to work because the RUSTC env variable was unset, and so autocfg bypassed Miri and queried the
rustc
binary, which usually is pretty much in sync with themiri
binary that actually does all the building and running here, but there is no guarantee of that. It basically used to work by chance.Since recently (to fix some other issues), RUSTC is now set to the
miri
binary. And now autocfg does not work any more. I don't quite know what fails yet -- looks like autocfg suppresses all rustc output, so I'll need to work with a patched autocfg to debug any of this (or if you have better ways of debugging autocfg that'd be great to know :). But it might be that the best way to fix this is to make autocfg aware of Miri and adjust its behavior.The text was updated successfully, but these errors were encountered: