From 5c56aa70012cd47b2892a17c5665212fe864126e Mon Sep 17 00:00:00 2001 From: Levi Bostian Date: Wed, 18 Jan 2023 10:13:28 -0600 Subject: [PATCH] fix: remove currentRoute parameter in in-app event listener Team did not mention this parameter is needed. It has also been removed in iOS SDK --- messaginginapp/api/messaginginapp.api | 2 +- .../messaginginapp/provider/GistInAppMessagesProvider.kt | 2 +- .../java/io/customer/messaginginapp/type/InAppEventListener.kt | 2 +- .../io/customer/messaginginapp/InAppMessagesProviderTest.kt | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/messaginginapp/api/messaginginapp.api b/messaginginapp/api/messaginginapp.api index d94b03e3c..c10a4c6b1 100644 --- a/messaginginapp/api/messaginginapp.api +++ b/messaginginapp/api/messaginginapp.api @@ -26,7 +26,7 @@ public final class io/customer/messaginginapp/ModuleMessagingInApp : io/customer public abstract interface class io/customer/messaginginapp/type/InAppEventListener { public abstract fun errorWithMessage (Lio/customer/messaginginapp/type/InAppMessage;)V - public abstract fun messageActionTaken (Lio/customer/messaginginapp/type/InAppMessage;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)V + public abstract fun messageActionTaken (Lio/customer/messaginginapp/type/InAppMessage;Ljava/lang/String;Ljava/lang/String;)V public abstract fun messageDismissed (Lio/customer/messaginginapp/type/InAppMessage;)V public abstract fun messageShown (Lio/customer/messaginginapp/type/InAppMessage;)V } diff --git a/messaginginapp/src/main/java/io/customer/messaginginapp/provider/GistInAppMessagesProvider.kt b/messaginginapp/src/main/java/io/customer/messaginginapp/provider/GistInAppMessagesProvider.kt index 1eea8ee49..2b22b7771 100644 --- a/messaginginapp/src/main/java/io/customer/messaginginapp/provider/GistInAppMessagesProvider.kt +++ b/messaginginapp/src/main/java/io/customer/messaginginapp/provider/GistInAppMessagesProvider.kt @@ -74,7 +74,7 @@ internal class GistInAppMessagesProvider(private val provider: GistApi) : override fun embedMessage(message: Message, elementId: String) {} override fun onAction(message: Message, currentRoute: String, action: String, name: String) { - listener?.messageActionTaken(InAppMessage.getFromGistMessage(message), currentRoute = currentRoute, action = action, name = name) + listener?.messageActionTaken(InAppMessage.getFromGistMessage(message), action = action, name = name) } override fun onError(message: Message) { diff --git a/messaginginapp/src/main/java/io/customer/messaginginapp/type/InAppEventListener.kt b/messaginginapp/src/main/java/io/customer/messaginginapp/type/InAppEventListener.kt index 30dd8c296..bc2e88e57 100644 --- a/messaginginapp/src/main/java/io/customer/messaginginapp/type/InAppEventListener.kt +++ b/messaginginapp/src/main/java/io/customer/messaginginapp/type/InAppEventListener.kt @@ -4,5 +4,5 @@ interface InAppEventListener { fun messageShown(message: InAppMessage) fun messageDismissed(message: InAppMessage) fun errorWithMessage(message: InAppMessage) - fun messageActionTaken(message: InAppMessage, currentRoute: String, action: String, name: String) + fun messageActionTaken(message: InAppMessage, action: String, name: String) } diff --git a/messaginginapp/src/sharedTest/java/io/customer/messaginginapp/InAppMessagesProviderTest.kt b/messaginginapp/src/sharedTest/java/io/customer/messaginginapp/InAppMessagesProviderTest.kt index eaeac3712..9238193fa 100644 --- a/messaginginapp/src/sharedTest/java/io/customer/messaginginapp/InAppMessagesProviderTest.kt +++ b/messaginginapp/src/sharedTest/java/io/customer/messaginginapp/InAppMessagesProviderTest.kt @@ -179,7 +179,7 @@ internal class InAppMessagesProviderTest : BaseTest() { val givenAction = String.random val givenName = String.random gistInAppMessagesProvider.onAction(givenMessage, givenCurrentRoute, givenAction, givenName) - verify(eventListenerMock).messageActionTaken(expectedInAppMessage, currentRoute = givenCurrentRoute, action = givenAction, name = givenName) + verify(eventListenerMock).messageActionTaken(expectedInAppMessage, action = givenAction, name = givenName) } @Test