Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes non async call async_forward_entry_setup #390

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

rrooggiieerr
Copy link
Contributor

Fixes #386

@rrooggiieerr
Copy link
Contributor Author

Sorry, not entirely sure yet if this fixes it, will look further into it later

@rrooggiieerr
Copy link
Contributor Author

Ok, this does fixes the non async call async_forward_entry_setup, however bb4bc52 breaks my system. Withouth bb4bc52 and with this fix my system works ok and without the Detected that custom integration 'nordpool' calls async_forward_entry_setup for integration, nordpool warning

@rrooggiieerr rrooggiieerr reopened this Jul 4, 2024
@sofkaski
Copy link

I can confirm @rrooggiieerr 's observation. Dropping out the offending commit this PR works in my system without any warning about sync calls. (When not dropped fails if tomorrows data is not available).

@sofkaski
Copy link

sofkaski commented Jul 28, 2024

One review comment: It would be nice to squash commits related to the fix to one commit, but leave the nordpool library update as a separate commit. This would make the git history cleaner.

@tarvip
Copy link

tarvip commented Aug 5, 2024

I tested [master](rrooggiieerr:master) version over weekend. It seems to work, however, most annoying thing is that when you restart HA in the morning then nordpool integration is not getting ready (probably because next day prices are not yet available).

In the log there is following message repeating:

[homeassistant.bootstrap] Waiting on integrations to complete setup: {('nordpool', '140298303296896'): 4058056.273756177}

This caused issues for everything else that is using this integration. Reverted back to 0.0.14, at least no issues with restart.

@JkJ076
Copy link

JkJ076 commented Aug 8, 2024

This is still an issue; updated HomeAssistant to latest version; 2024.8.0

Got this in my logg -

Logger: homeassistant.helpers.frame
Källa: helpers/frame.py:151
Inträffade först: 19:31:27 (1 händelser)
Senast loggade: 19:31:27

Detected code that calls async_forward_entry_setup for integration nordpool with title: Nordpool and entry_id: a1cfb4c3b72bcbcf3615fea1633de40f, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.

@rrooggiieerr
Copy link
Contributor Author

@tarvip , you should revert bb4bc52 to make it also work in the morning.

Unfortunately there hasn't been a version released by the integration owner yet which contains all the needed changes to make it work

@Hellowlol Hellowlol merged commit 010bbc8 into custom-components:master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'nordpool' calls async_forward_entry_setup for integration
5 participants