-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes non async call async_forward_entry_setup #390
Conversation
Sorry, not entirely sure yet if this fixes it, will look further into it later |
I can confirm @rrooggiieerr 's observation. Dropping out the offending commit this PR works in my system without any warning about sync calls. (When not dropped fails if tomorrows data is not available). |
One review comment: It would be nice to squash commits related to the fix to one commit, but leave the nordpool library update as a separate commit. This would make the git history cleaner. |
I tested In the log there is following message repeating:
This caused issues for everything else that is using this integration. Reverted back to |
This is still an issue; updated HomeAssistant to latest version; 2024.8.0 Got this in my logg - Logger: homeassistant.helpers.frame Detected code that calls async_forward_entry_setup for integration nordpool with title: Nordpool and entry_id: a1cfb4c3b72bcbcf3615fea1633de40f, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue. |
Fixes #386