Pass areas down to aio_price.py to avoid errors unrelated to selected area #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338
This PR adds a try-except when fetching prices for today, to avoid complete failures and stacktraces in the log. If this is undesired, feel free to remove it.
This PR also changed some functions to keep a list of fetched areas and pass them to the underlying functions, so only values in the areas of interest are parsed, and therefore only invalid data in those areas will result in an exception.
I've tested the code on my private instance for several days, and it fetches the correct area with exceptions at the correct time
Due to
aio_price.fetch
fetching all areas, a single invalid value in the time-range for any area will result in raising anInvalidValueException
, which wasn't handled and thus results in failure. My instance is only set up to track DK1, and with some more logging i found out that the error was caused by an invalid value for the AT-area:Debuglog before this PR:
Debuglog after: