Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Things to discuss with @pokey #4

Open
1 task
phillco opened this issue Jun 4, 2022 · 3 comments
Open
1 task

Things to discuss with @pokey #4

phillco opened this issue Jun 4, 2022 · 3 comments
Assignees
@pokey

Comments

@phillco
Copy link
Member

phillco commented Jun 4, 2022

  • Are hats only ever one character? Currently we export a start/and range because it the decoration range
@phillco phillco changed the title Things to discuss with pokey Things to discuss with @pokey Jun 4, 2022
@pokey
Copy link
Collaborator

pokey commented Jun 4, 2022 •
edited
Loading

Today they're only one character, but it's possible they could be more than one in the future, eg cursorless-dev/cursorless#71 (and potentially cursorless-dev/cursorless#276)

I wouldn't go crazy trying to support more than one character, but if it doesn't make life harder I'd be inclined to support ranges

@phillco
Copy link
Member Author

phillco commented Jun 4, 2022

OK. @rntz was a little confused about the API in the JSON that we were writing, since they were expressed as ranges but were only ever one character long. Guess we'll leave them as ranges for now!

@pokey
Copy link
Collaborator

pokey commented Jun 4, 2022

Yeah that's fair. If you think it will be simpler / less confusing to assume they're one char, that's prob fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pokey pokey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillco @pokey