feat: add message when build id is not supported #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoldis
requested changes
Dec 29, 2022
packages/cypress-cloud/index.ts
Outdated
| * The process will stop if we cannot do it | ||
| * https://docs.cypress.io/guides/references/error-messages#We-could-not-determine-a-unique-CI-build-ID | ||
| */ | ||
| function checkForCiBuildFromCi() { |
There was a problem hiding this comment.
- This file becomes too bloated, please move into `ciProvider
- We implemented programmatic API access via
runfunction - we don't want the upstream program to just exit. Please throw an exception instead. - Please move this validation into
ciProvider->getCI.getCIcan get the explicitciBuildIdas a parameter,
agoldis
requested changes
Dec 29, 2022
agoldis
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54
Adding a function that will check for support of build ID from CI environment variables.
I am unsure if the message is informative enough or if we should add a link to the documentation. @agoldis What do you think?