Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress as a peerDependency for yarn/pnpm #116

Merged
merged 3 commits into from
Apr 9, 2023

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Apr 5, 2023

Add cypress as a peerDependency so that more strict package managers like Yarn 2+ & pnpm know to symlink the right cypress version in.

In a monorepo with multiple cypress versions, without this cypress versions, cypress-cloud might require.resolve to the wrong cypress version.

Closes #117

@agoldis
Copy link
Contributor

agoldis commented Apr 5, 2023

Thanks @segevfiner! 👀

@agoldis agoldis merged commit 97f9465 into currents-dev:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using pnpm "monorepo" with multiple cypress versions, resolves to wrong cypress binary
2 participants