Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement components new designs #98

Closed
17 tasks done
bestatigen opened this issue Nov 2, 2021 · 4 comments · Fixed by #175
Closed
17 tasks done

Implement components new designs #98

bestatigen opened this issue Nov 2, 2021 · 4 comments · Fixed by #175
Assignees

Comments

@bestatigen
Copy link
Collaborator

bestatigen commented Nov 2, 2021

Overview

The new designs are available on Figma.
.
The structure of the pages under examples/frontend stays the same so this should for the most part be about updating theme-ui to use the new style guide (to be extracted from the Figma).
Preferably supporting two themes (light/dark) from the beginning would be great, and to keep an eye on while updating the current component's styles; for how the code is now it shouldn't be too much overhead.

Instead of me creating an issue for each of the components that need to be updated, you can create issues when you pick up the component you are working on.

I can only think of font and theme to change as overall configurations now, but if you find something else needs to be updated feel free to create an issue for it.


Issues

Components

Leave last

@bestatigen bestatigen added the Epic label Nov 2, 2021
@bestatigen bestatigen self-assigned this Nov 2, 2021
@sekaiking
Copy link
Contributor

Hey @devey, I think it would be good to have a different branch for design where we open pull requests and merge until the design is fully implemented. Because the design will look weird when some components are updated and some aren't.

I made a new branch called design_update which should be the same as master but with the new design. And all design PRs should go there and be reviewed and merged, and once we are done from the design we can merge it into master.

@bestatigen
Copy link
Collaborator Author

Sounds good, @achrafismyname! Thanks for setting it up; it makes sense to have this until the new designs are merged. If you want to take charge of this Epic and add the missing issues to it based on what needs to work on, that would be great!

@sekaiking
Copy link
Contributor

okay I can do that!

@github-actions
Copy link

🎉 This issue has been resolved in version @cura/components-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants