-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement components new designs #98
Comments
Hey @devey, I think it would be good to have a different branch for design where we open pull requests and merge until the design is fully implemented. Because the design will look weird when some components are updated and some aren't. I made a new branch called |
Sounds good, @achrafismyname! Thanks for setting it up; it makes sense to have this until the new designs are merged. If you want to take charge of this Epic and add the missing issues to it based on what needs to work on, that would be great! |
okay I can do that! |
🎉 This issue has been resolved in version @cura/components-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
The new designs are available on Figma.
.
The structure of the pages under
examples/frontend
stays the same so this should for the most part be about updatingtheme-ui
to use the new style guide (to be extracted from the Figma).Preferably supporting two themes (
light
/dark
) from the beginning would be great, and to keep an eye on while updating the current component's styles; for how the code is now it shouldn't be too much overhead.Instead of me creating an issue for each of the components that need to be updated, you can create issues when you pick up the component you are working on.
I can only think of font and theme to change as overall configurations now, but if you find something else needs to be updated feel free to create an issue for it.
Issues
Components
Bidders
component #158Metadata
component #162Footer
component #161CreatorShare
component #160BiddersBids
component #159Bidders
component #158BidCreate
component #157NFTE
component #163Leave last
The text was updated successfully, but these errors were encountered: