Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of Plugins execution when listed with plugin seek-oss/aws-sm#v2.2.1 #23

Open
Sachin155 opened this issue Jun 28, 2022 · 2 comments

Comments

@Sachin155
Copy link

I have configured the steps where plugins listed in order

  - cultureamp/aws-assume-role#v0.1.0:
      role: "arn:aws:iam::1111111111111:role/buildkite-roles"
  - seek-oss/aws-sm#v2.2.1:
      env:
        GITHUB_TOKEN:
          secret-id: "buildkite-secret"
          json-key: ".github_token"

According to the documentation the plugins order of execution is based on the hooks defind here

Since the plugin cultureamp/aws-assume-role#v0.1.0 hook does not have a definition for environment, the secrets-manager's plugin hooks run before the aws-assume-role plugin's hook. due to which the pipeline job fails since agent underlying role does not access to secrets-manager.

Any suggestions would help.

@ishaqsharief318
Copy link

@Sachin155 - Tried the same thing and it looks like the aws-sm plugin is evaluated during the running environment hook stage as per this comment ( scroll all the way to the end ).

I'd be interested in knowing how you solved this issue

@jt-shippit
Copy link

Hi, We are starting to play with seek-oss/aws-sm and found this issue. I haven't tested it yet, but I wonder if a possible workaround would be to use the assume-role plugin to start a new sub-pipeline using the command buildkite-agent pipeline upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants